pgsql: Fix infer_arbiter_index for partitioned tables

From: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix infer_arbiter_index for partitioned tables
Date: 2025-12-11 19:58:03
Message-ID: E1vTmna-000CwK-05@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix infer_arbiter_index for partitioned tables

The fix for concurrent index operations in bc32a12e0db2 started
considering indexes that are not yet marked indisvalid as arbiters for
INSERT ON CONFLICT. For partitioned tables, this leads to including
indexes that may not exist in partitions, causing a trivially
reproducible "invalid arbiter index list" error to be thrown because of
failure to match the index. To fix, it suffices to ignore !indisvalid
indexes on partitioned tables. There should be no risk that the set of
indexes will change for concurrent transactions, because in order for
such an index to be marked valid, an ALTER INDEX ATTACH PARTITION must
run which requires AccessExclusiveLock.

Author: Mihail Nikalayeu <mihailnikalayeu(at)gmail(dot)com>
Reported-by: Alexander Lakhin <exclusion(at)gmail(dot)com>
Reviewed-by: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
Discussion: https://postgr.es/m/17622f79-117a-4a44-aa8e-0374e53faaf0%40gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/81f72115cf189b0a428d3efca2e4beb02b825111

Modified Files
--------------
src/backend/optimizer/util/plancat.c | 9 +++++++++
src/test/regress/expected/partition_info.out | 7 +++++++
src/test/regress/sql/partition_info.sql | 8 ++++++++
3 files changed, 24 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Nathan Bossart 2025-12-11 21:13:09 pgsql: Fix some comments.
Previous Message Heikki Linnakangas 2025-12-11 14:02:39 pgsql: Fix comment on how temp files and subtransactions are handled