pgsql: Allow PG_PRINTF_ATTRIBUTE to be different in C and C++ code.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Allow PG_PRINTF_ATTRIBUTE to be different in C and C++ code.
Date: 2025-12-10 22:09:32
Message-ID: E1vTSNH-0002mm-2l@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Allow PG_PRINTF_ATTRIBUTE to be different in C and C++ code.

Although clang claims to be compatible with gcc's printf format
archetypes, this appears to be a falsehood: it likes __syslog__
(which gcc does not, on most platforms) and doesn't accept
gnu_printf. This means that if you try to use gcc with clang++
or clang with g++, you get compiler warnings when compiling
printf-like calls in our C++ code. This has been true for quite
awhile, but it's gotten more annoying with the recent appearance
of several buildfarm members that are configured like this.

To fix, run separate probes for the format archetype to use with the
C and C++ compilers, and conditionally define PG_PRINTF_ATTRIBUTE
depending on __cplusplus.

(We could alternatively insist that you not mix-and-match C and
C++ compilers; but if the case works otherwise, this is a poor
reason to insist on that.)

No back-patch for now, but we may want to do that if this
patch survives buildfarm testing.

Discussion: https://postgr.es/m/986485.1764825548@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/0909380e4c9aa22b75dfe5a7e33393b48078db81

Modified Files
--------------
config/c-compiler.m4 | 46 +++++++++++++++++++---
configure | 96 ++++++++++++++++++++++++++++++++++++++++++++--
configure.ac | 1 +
meson.build | 17 +++++++-
src/include/c.h | 10 +++++
src/include/pg_config.h.in | 11 ++++--
6 files changed, 169 insertions(+), 12 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Geoghegan 2025-12-10 22:14:06 Re: pgsql: Widen MultiXactOffset to 64 bits
Previous Message Peter Geoghegan 2025-12-10 20:36:02 pgsql: Return TIDs in desc order during backwards scans.