pgsql: Fix bogus extra arguments to query_safe in test

From: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix bogus extra arguments to query_safe in test
Date: 2025-12-10 17:58:51
Message-ID: E1vTOSg-0000w5-1Q@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix bogus extra arguments to query_safe in test

The test seemed to incorrectly think that query_safe() takes an
argument that describes what the query does, similar to e.g.
command_ok(). Until commit bd8d9c9bdf the extra arguments were
harmless and were just ignored, but when commit bd8d9c9bdf introduced
a new optional argument to query_safe(), the extra arguments started
clashing with that, causing the test to fail.

Backpatch to v17, that's the oldest branch where the test exists. The
extra arguments didn't cause any trouble on the older branches, but
they were clearly bogus anyway.

Branch
------
REL_18_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/e08f338d0028af6f9f54616df1cb51009504eee3

Modified Files
--------------
src/test/modules/xid_wraparound/t/004_notify_freeze.pl | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Jeff Davis 2025-12-10 19:56:56 pgsql: Add pg_iswcased().
Previous Message Heikki Linnakangas 2025-12-10 17:32:12 pgsql: Improve DDL deparsing test