pgsql: Make stats_ext test faster under cache-clobbering test condition

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Make stats_ext test faster under cache-clobbering test condition
Date: 2025-12-03 18:23:57
Message-ID: E1vQrW8-002dKl-1g@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Make stats_ext test faster under cache-clobbering test conditions.

Commit 1eccb9315 added a test case that will cause a large number
of evaluations of a plpgsql function. With -DCLOBBER_CACHE_ALWAYS,
that takes an unreasonable amount of time (hours) because the
function's cache entries are repeatedly deleted and rebuilt.
That doesn't add any useful test coverage --- other test cases
already exercise plpgsql well enough --- and it's not part of what
this test intended to cover. We can get the same planner coverage,
if not more, by making the test directly invoke numeric_lt().

Reported-by: Tomas Vondra <tomas(at)vondra(dot)me>
Author: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Discussion: https://postgr.es/m/baf1ae02-83bd-4f5d-872a-1d04f11a9073@vondra.me

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/8d61228717e619b90b8ebd1d219d006b920e00e5

Modified Files
--------------
src/test/regress/expected/stats_ext.out | 10 +++-------
src/test/regress/sql/stats_ext.sql | 11 +++--------
2 files changed, 6 insertions(+), 15 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2025-12-03 23:40:47 pgsql: Add pg_atomic_unlocked_write_u64
Previous Message Heikki Linnakangas 2025-12-03 17:49:18 pgsql: Add test for multixid wraparound