pgsql: Add pg_add_size_overflow() and friends

From: Jacob Champion <jchampion(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Add pg_add_size_overflow() and friends
Date: 2025-11-24 20:24:28
Message-ID: E1vNd6p-001E3S-23@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Add pg_add_size_overflow() and friends

Commit 600086f47 added (several bespoke copies of) size_t addition with
overflow checks to libpq. Move this to common/int.h, along with
its subtraction and multiplication counterparts.

pg_neg_size_overflow() is intentionally omitted; I'm not sure we should
add SSIZE_MAX to win32_port.h for the sake of a function with no
callers.

Reviewed-by: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Reviewed-by: Michael Paquier <michael(at)paquier(dot)xyz>
Discussion: https://postgr.es/m/CAOYmi%2B%3D%2BpqUd2MUitvgW1pAJuXgG_TKCVc3_Ek7pe8z9nkf%2BAg%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/8934f2136cd82333fd148954a13a8ab01f7bd7ef

Modified Files
--------------
src/include/common/int.h | 67 +++++++++++++++++++++++++++++++++++++
src/interfaces/libpq/fe-exec.c | 44 +++++++-----------------
src/interfaces/libpq/fe-print.c | 36 +++++---------------
src/interfaces/libpq/fe-protocol3.c | 27 +++------------
4 files changed, 91 insertions(+), 83 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2025-11-24 21:02:18 Re: pgsql: Teach DSM registry to ERROR if attaching to an uninitialized ent
Previous Message Nathan Bossart 2025-11-24 19:03:06 Re: pgsql: Teach DSM registry to ERROR if attaching to an uninitialized ent