pgsql: Remove obsolete cast

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Remove obsolete cast
Date: 2025-11-20 07:20:02
Message-ID: E1vLyxV-000QSm-2F@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove obsolete cast

The upstream timezone code uses a bool variable as an array subscript.
Back when PostgreSQL's bool was char, this would have caused a warning
from gcc -Wchar-subscripts, which is included in -Wall. But this has
been obsolete since probably commit d26a810ebf9, but certainly since
bool is now the C standard bool. So we can remove this deviation from
the upstream code, to make future code merges simpler.

Reviewed-by: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Discussion: https://www.postgresql.org/message-id/flat/9ad2749f-77ab-4ecb-a321-1ca915480b05%40eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b5623cc5e4197b59d37b869fbd92c1778be0438e

Modified Files
--------------
src/timezone/localtime.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tomas Vondra 2025-11-20 12:50:11 pgsql: Handle EPERM in pg_numa_init
Previous Message Fujii Masao 2025-11-20 00:21:40 pgsql: doc: Update pg_upgrade documentation to match recent description