pgsql: Drop support for MSVCRT's %I64 format strings.

From: Thomas Munro <tmunro(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Drop support for MSVCRT's %I64 format strings.
Date: 2025-11-19 21:10:30
Message-ID: E1vLpRd-000MEH-1b@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Drop support for MSVCRT's %I64 format strings.

MSVCRT predated C99 and invented non-standard placeholders for 64-bit
numbers, and then later used them in standard macros when C99
<inttypes.h> arrived. The macros just use %lld etc when building with
UCRT, so there should be no way for our interposed sprintf.c code to
receive the pre-standard kind these days. Time to drop the code that
parses them.

That code was in fact already dead when commit 962da900 landed, as we'd
disclaimed MSVCRT support a couple of weeks earlier in commit 1758d424,
but patch development overlapped and the history of these macros hadn't
been investigated.

Reviewed-by: Peter Eisentraut <peter(at)eisentraut(dot)org>
Discussion: https://postgr.es/m/4d8b1a67-aab2-4429-b44b-f03988095939%40eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/7ab9b34614c2d6f69070a667787e0b091ecb72b1

Modified Files
--------------
src/port/snprintf.c | 44 --------------------------------------------
1 file changed, 44 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Thomas Munro 2025-11-19 21:39:59 pgsql: Drop support for MSVCRT's float formatting quirk.
Previous Message Tom Lane 2025-11-19 18:22:23 pgsql: Speed up eqjoinsel() with lots of MCV entries.