pgsql: Teach DSM registry to ERROR if attaching to an uninitialized ent

From: Nathan Bossart <nathan(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Teach DSM registry to ERROR if attaching to an uninitialized ent
Date: 2025-11-12 20:31:11
Message-ID: E1vJHUl-006I7v-00@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Teach DSM registry to ERROR if attaching to an uninitialized entry.

If DSM entry initialization fails, backends could try to use an
uninitialized DSM segment, DSA, or dshash table (since the entry is
still added to the registry). To fix, keep track of whether
initialization completed, and ERROR if a backend tries to attach to
an uninitialized entry. We could instead retry initialization as
needed, but that seemed complicated, error prone, and unlikely to
help most cases. Furthermore, such problems probably indicate a
coding error.

Reported-by: Alexander Lakhin <exclusion(at)gmail(dot)com>
Reviewed-by: Sami Imseih <samimseih(at)gmail(dot)com>
Discussion: https://postgr.es/m/dd36d384-55df-4fc2-825c-5bc56c950fa9%40gmail.com
Backpatch-through: 17

Branch
------
REL_17_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/ac2800ddc185615aaf8547a051b324592340b666

Modified Files
--------------
src/backend/storage/ipc/dsm_registry.c | 19 ++++++++++++++-----
1 file changed, 14 insertions(+), 5 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Nathan Bossart 2025-11-12 20:58:28 pgsql: test_dsa: Avoid leaking LWLock tranches.
Previous Message Nathan Bossart 2025-11-12 20:31:10 pgsql: Teach DSM registry to ERROR if attaching to an uninitialized ent