pgsql: ci: Add missing "set -e" to scripts run by su.

From: Thomas Munro <tmunro(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: ci: Add missing "set -e" to scripts run by su.
Date: 2025-11-06 01:28:03
Message-ID: E1vGonD-005DbJ-1V@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

ci: Add missing "set -e" to scripts run by su.

If any shell command fails, the whole script should fail. To avoid
future omissions, add this even for single-command scripts that use su
with heredoc syntax, as they might be extended or copied-and-pasted.

Extracted from a larger patch that wanted to use #error during
compilation, leading to the diagnosis of this problem.

Reviewed-by: Tristan Partin <tristan(at)partin(dot)io> (earlier version)
Discussion: https://postgr.es/m/DDZP25P4VZ48.3LWMZBGA1K9RH%40partin.io
Backpatch-through: 15

Branch
------
REL_18_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/ae2381025a4c77662ed5a56c062cbf3355c3d618

Modified Files
--------------
.cirrus.tasks.yml | 16 ++++++++++++++++
1 file changed, 16 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Thomas Munro 2025-11-06 01:28:19 pgsql: ci: Add missing "set -e" to scripts run by su.
Previous Message Thomas Munro 2025-11-06 01:27:50 pgsql: ci: Add missing "set -e" to scripts run by su.