pgsql: Simplify newline handling in libpq TAP test

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Simplify newline handling in libpq TAP test
Date: 2025-10-29 00:58:47
Message-ID: E1vDuWV-0040GI-06@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Simplify newline handling in libpq TAP test

CRLF translation is already handled by the text mode, so there should be
no need for any specific logic. See also 1c6d4629394d, msys perl being
one case where the translation mattered.

Note: An equivalent has been first applied on HEAD with 8767b449a3a1.
The same change is backpatched to v18 as all the Windows buildfarm
members have reported green.

Author: Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>
Co-authored-by: Michael Paquier <michael(at)paquier(dot)xyz>
Reviewed-by: Daniel Gustafsson <daniel(at)yesql(dot)se>
Discussion: https://postgr.es/m/aPsh39bxwYKvUlAf@paquier.xyz
Backpatch-through: 18

Branch
------
REL_18_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/a92bbffbc3a7157b0998f0423cf2304c81626822

Modified Files
--------------
src/interfaces/libpq/t/006_service.pl | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2025-10-29 06:34:47 pgsql: Remove obsolete comment
Previous Message Michael Paquier 2025-10-29 00:14:10 pgsql: Fix correctness issue with computation of FPI size in WAL stats