pgsql: pg_rewind: Extend code detecting relation files to work with WAL

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: pg_rewind: Extend code detecting relation files to work with WAL
Date: 2025-10-23 07:00:15
Message-ID: E1vBpJ1-0035Ca-1q@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

pg_rewind: Extend code detecting relation files to work with WAL files

isRelDataFile() is renamed to getFileContentType(), extended so as it
becomes able to detect more file patterns than only relation files. The
new file name pattern that can be detected is WAL files.

This refactoring has been suggested by Robert Haas. This will be used
in a follow-up patch where we are looking at improving how WAL files are
processed by pg_rewind. As of this change, WAL files are still handled
the same way as previously, always copied from the source to the target
server.

Extracted from a larger patch by the same authors.

Author: John Hsu <johnhyvr(at)gmail(dot)com>
Author: Justin Kwan <justinpkwan(at)outlook(dot)com>
Reviewed-by: Japin Li <japinli(at)hotmail(dot)com>
Reviewed-by: Srinath Reddy Sadipiralla <srinath2133(at)gmail(dot)com>
Discussion: https://postgr.es/m/181b4c6fa9c.b8b725681941212.7547232617810891479@viggy28.dev

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/6ae08d9583e9a5e951286948bdd9fcd58e67718a

Modified Files
--------------
src/bin/pg_rewind/filemap.c | 60 ++++++++++++++++++++++++++--------------
src/bin/pg_rewind/filemap.h | 9 +++++-
src/tools/pgindent/typedefs.list | 1 +
3 files changed, 48 insertions(+), 22 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Amit Kapila 2025-10-23 08:43:54 pgsql: Introduce "REFRESH SEQUENCES" for subscriptions.
Previous Message Fujii Masao 2025-10-23 04:29:08 pgsql: Add comments explaining overflow entries in the replication lag