| From: | Fujii Masao <fujii(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Add comments explaining overflow entries in the replication lag |
| Date: | 2025-10-23 04:27:25 |
| Message-ID: | E1vBmv7-00347u-2N@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Add comments explaining overflow entries in the replication lag tracker.
Commit 883a95646a8 introduced overflow entries in the replication lag tracker
to fix an issue where lag columns in pg_stat_replication could stall when
the replay LSN stopped advancing.
This commit adds comments clarifying the purpose and behavior of overflow
entries to improve code readability and understanding.
Since commit 883a95646a8 was recently applied and backpatched to all
supported branches, this follow-up commit is also backpatched accordingly.
Author: Xuneng Zhou <xunengzhou(at)gmail(dot)com>
Reviewed-by: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Discussion: https://postgr.es/m/CABPTF7VxqQA_DePxyZ7Y8V+ErYyXkmwJ1P6NC+YC+cvxMipWKw@mail.gmail.com
Backpatch-through: 13
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/abc2b71383b4c49c2fbda74c281d50f3936551b8
Modified Files
--------------
src/backend/replication/walsender.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2025-10-23 04:27:49 | pgsql: Add comments explaining overflow entries in the replication lag |
| Previous Message | Tatsuo Ishii | 2025-10-23 02:05:35 | pgsql: Fix coding style with "else". |