pgsql: Fix reset of incorrect hash iterator in GROUPING SETS queries

From: David Rowley <drowley(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix reset of incorrect hash iterator in GROUPING SETS queries
Date: 2025-10-18 03:07:33
Message-ID: E1v9xI5-002Ehy-2K@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix reset of incorrect hash iterator in GROUPING SETS queries

This fixes an unlikely issue when fetching GROUPING SET results from
their internally stored hash tables. It was possible in rare cases that
the hash iterator would be set up incorrectly which could result in a
crash.

This was introduced in 4d143509c, so backpatch to v18.

Many thanks to Yuri Zamyatin for reporting and helping to debug this
issue.

Bug: #19078
Reported-by: Yuri Zamyatin <yuri(at)yrz(dot)am>
Author: David Rowley <dgrowleyml(at)gmail(dot)com>
Reviewed-by: Jeff Davis <pgsql(at)j-davis(dot)com>
Discussion: https://postgr.es/m/19078-dfd62f840a2c0766@postgresql.org
Backpatch-through: 18

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/5c0a20003b4396930a354105ccf47402ca5047d2

Modified Files
--------------
src/backend/executor/nodeAgg.c | 2 +-
src/include/lib/simplehash.h | 4 ++++
2 files changed, 5 insertions(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message David Rowley 2025-10-18 03:07:57 pgsql: Fix reset of incorrect hash iterator in GROUPING SETS queries
Previous Message David Rowley 2025-10-17 23:50:30 pgsql: Englishify comment wording