From: | Daniel Gustafsson <dgustafsson(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Avoid warnings in tests when openssl binary isn't available |
Date: | 2025-10-17 13:05:47 |
Message-ID: | E1v9k9T-00291G-1a@gemulon.postgresql.org |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Avoid warnings in tests when openssl binary isn't available
The SSL tests for pg_stat_ssl tries to exactly match the serial
from the certificate by extracting it with the openssl binary.
If that fails due to the binary not being available, a fallback
match is used, but the attempt to execute a missing binary adds
a warning to the output which can confuse readers for a failure
in the test. Fix by only attempting if the openssl binary was
found by autoconf/meson.
Backpatch down to v16 where commit c8e4030d1bdd made the test
use the OPENSSL variable from autoconf/meson instead of a hard-
coded value.
Author: Daniel Gustafsson <daniel(at)yesql(dot)se>
Reported-by: Christoph Berg <myon(at)debian(dot)org>
Discussion: https://postgr.es/m/aNPSp1-RIAs3skZm@msg.df7cb.de
Backpatch-through: 16
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/7d129ba54e7425baf43aa518d417ba3e4e94a443
Modified Files
--------------
src/test/ssl/t/001_ssltests.pl | 42 +++++++++++++++++++-----------------------
1 file changed, 19 insertions(+), 23 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Daniel Gustafsson | 2025-10-17 13:11:51 | pgsql: Avoid warnings in tests when openssl binary isn't available |
Previous Message | Peter Eisentraut | 2025-10-17 08:37:52 | pgsql: Change config_generic.vartype to be initialized at compile time |