| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Remove overzealous _bt_killitems assertion. |
| Date: | 2025-10-10 18:52:38 |
| Message-ID: | E1v7IEI-0012v0-0a@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Remove overzealous _bt_killitems assertion.
An assertion in _bt_killitems expected the scan's currPos state to
contain a valid LSN, saved from when currPos's page was initially read.
The assertion failed to account for the fact that even logged relations
can have leaf pages with an invalid LSN when built with wal_level set to
"minimal". Remove the faulty assertion.
Oversight in commit e6eed40e (though note that the assertion was
backpatched to stable branches before 18 by commit 7c319f54).
Author: Peter Geoghegan <pg(at)bowt(dot)ie>
Reported-By: Matthijs van der Vleuten <postgresql(at)zr40(dot)nl>
Bug: #19082
Discussion: https://postgr.es/m/19082-628e62160dbbc1c1@postgresql.org
Backpatch-through: 13
Branch
------
REL_14_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/314004021e549770d3d57fd0cf286050b948472d
Modified Files
--------------
src/backend/access/nbtree/nbtutils.c | 1 -
1 file changed, 1 deletion(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Álvaro Herrera | 2025-10-11 14:48:27 | pgsql: dbase_redo: Fix Valgrind-reported memory leak |
| Previous Message | Michael Paquier | 2025-10-10 02:52:28 | pgsql: Fix two typos in xlogstats.h and xlogstats.c |