pgsql: Cleanup NAN code in float.h, too.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Cleanup NAN code in float.h, too.
Date: 2025-10-08 16:19:59
Message-ID: E1v6WtT-000hPf-0x@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Cleanup NAN code in float.h, too.

In the same spirit as 3bf905692, assume that all compilers we still
support provide the NAN macro, and get rid of workarounds for that.

The C standard allows implementations to omit NAN if the underlying
float arithmetic lacks quiet (non-signaling) NaNs. However, we've
required that feature for years: the workarounds only supported
lack of the macro, not lack of the functionality. I put in a
compile-time #error if there's no macro, just for clarity.

Also fix up the copies of these functions in ecpglib, and leave
a breadcrumb for the next hacker who touches them.

History of the hacks being removed here can be found in commits
1bc2d544b, 4d17a2146, cec8394b5.

Author: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Discussion: https://postgr.es/m/1952095.1759764279@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/14ad0d7bf2b8d5f26061df7cbdf18cfffcdcb225

Modified Files
--------------
src/include/utils/float.h | 40 ++++++++++++++------------------------
src/interfaces/ecpg/ecpglib/data.c | 19 ++++--------------
2 files changed, 19 insertions(+), 40 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Masahiko Sawada 2025-10-08 17:05:21 pgsql: Add mem_exceeded_count column to pg_stat_replication_slots.
Previous Message Robert Haas 2025-10-08 13:31:02 pgsql: Add extension_state member to PlannedStmt.