pgsql: Fix Coverity issues reported in commit 25a30bbd423.

Fix Coverity issues reported in commit 25a30bbd423.

Fix several issues pointed out by Coverity (reported by Tome Lane).

- In row_is_in_frame(), return value of window_gettupleslot() was not
checked.

- WinGetFuncArgInPartition() tried to derefference "isout" pointer
even if it could be NULL in some places.

Besides the issues, I also fixed a compiler warning reported by Álvaro
Herrera.

Moreover, in WinGetFuncArgInPartition refactor the do...while loop so
that the codes inside the loop simpler. Also simplify the case when
abs_pos < 0.

Author: Tatsuo Ishii <ishii(at)postgresql(dot)org>
Reviewed-by: Paul Ramsey <pramsey(at)cleverelephant(dot)ca>
Reported-by: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Reported-by: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
Discussion: https://postgr.es/m/1686755.1759679957%40sss.pgh.pa.us
Discussion: https://postgr.es/m/202510051612.gw67jlc2iqpw%40alvherre.pgsql

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2273fa32bce7c1fb856c726d01d8cdaaba36f849

Modified Files
--------------
src/backend/executor/nodeWindowAgg.c | 77 ++++++++++++++++++------------------
1 file changed, 38 insertions(+), 39 deletions(-)