pgsql: Reorder XLogNeedsFlush() checks to be more consistent

Reorder XLogNeedsFlush() checks to be more consistent

During recovery, XLogNeedsFlush() checks the minimum recovery LSN point
instead of the flush LSN point. The same condition checks are used when
updating the minimum recovery point in UpdateMinRecoveryPoint(), but are
written in reverse order.

This commit makes the order of the checks consistent between
XLogNeedsFlush() and UpdateMinRecoveryPoint(), improving the code
clarity. Note that the second check (as ordered by this commit) relies
on InRecovery, which is true only in the startup process. So this makes
XLogNeedsFlush() cheaper in the startup process with the first check
acting as a shortcut while doing crash recovery, where
LocalMinRecoveryPoint is an invalid LSN.

Author: Melanie Plageman <melanieplageman(at)gmail(dot)com>
Reviewed-by: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
Discussion: https://postgr.es/m/aMIHNRTP6Wj6vw1s%40paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/bb68cde4136b02a7e51e8876891cd0a61c5726ca

Modified Files
--------------
src/backend/access/transam/xlog.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)