From: | David Rowley <drowley(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Add missing EPQ recheck for TID Scan |
Date: | 2025-09-16 23:50:27 |
Message-ID: | E1uyfRK-0014sW-32@gemulon.postgresql.org |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Add missing EPQ recheck for TID Scan
The EvalPlanQual recheck for TID Scan wasn't rechecking the TID qual
still passed after following update chains. This could result in tuples
being updated or deleted by plans using TID Scans where the ctid of the
new (updated) tuple no longer matches the clause of the scan. This isn't
desired behavior, and isn't consistent with what would happen if the
chosen plan had used an Index or Seq Scan, and that could lead to hard to
predict behavior for scans that contain TID quals and other quals as the
planner has freedom to choose TID or some other scan method for such
queries, and the chosen plan could change at any moment.
Here we fix this by properly implementing the recheck function for TID
Scans.
Backpatch to 13, oldest supported version
Reported-by: Sophie Alpert <pg(at)sophiebits(dot)com>
Author: Sophie Alpert <pg(at)sophiebits(dot)com>
Author: David Rowley <dgrowleyml(at)gmail(dot)com>
Reviewed-by: David Rowley <dgrowleyml(at)gmail(dot)com>
Reviewed-by: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Discussion: https://postgr.es/m/4a6268ff-3340-453a-9bf5-c98d51a6f729@app.fastmail.com
Backpatch-through: 13
Branch
------
REL_16_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/d6539f88b7c5bd2889dfdadc922c740bf5d3e0e4
Modified Files
--------------
src/backend/executor/nodeTidscan.c | 19 +++++--
src/test/isolation/expected/eval-plan-qual.out | 71 ++++++++++++++++++++++++++
src/test/isolation/specs/eval-plan-qual.spec | 11 ++++
3 files changed, 97 insertions(+), 4 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | David Rowley | 2025-09-16 23:50:50 | pgsql: Add missing EPQ recheck for TID Scan |
Previous Message | David Rowley | 2025-09-16 23:50:04 | pgsql: Add missing EPQ recheck for TID Scan |