From: | Richard Guo <rguo(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Treat JsonConstructorExpr as non-strict |
Date: | 2025-09-16 09:42:52 |
Message-ID: | E1uySD5-000z2i-25@gemulon.postgresql.org |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Treat JsonConstructorExpr as non-strict
JsonConstructorExpr can produce non-NULL output with a NULL input, so
it should be treated as a non-strict construct. Failing to do so can
lead to incorrect query behavior.
For example, in the reported case, when pulling up a subquery that is
under an outer join, if the subquery's target list contains a
JsonConstructorExpr that uses subquery variables and it is mistakenly
treated as strict, it will be pulled up without being wrapped in a
PlaceHolderVar. As a result, the expression will be evaluated at the
wrong place and will not be forced to null when the outer join should
do so.
Back-patch to v16 where JsonConstructorExpr was introduced.
Bug: #19046
Reported-by: Runyuan He <runyuan(at)berkeley(dot)edu>
Author: Tender Wang <tndrwang(at)gmail(dot)com>
Co-authored-by: Richard Guo <guofenglinux(at)gmail(dot)com>
Discussion: https://postgr.es/m/19046-765b6602b0a8cfdf@postgresql.org
Backpatch-through: 16
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/b63a822452152a7bd613fd4b28e0967e626e274e
Modified Files
--------------
src/backend/optimizer/util/clauses.c | 2 ++
src/test/regress/expected/subselect.out | 28 ++++++++++++++++++++++++++++
src/test/regress/sql/subselect.sql | 17 +++++++++++++++++
3 files changed, 47 insertions(+)
From | Date | Subject | |
---|---|---|---|
Next Message | Richard Guo | 2025-09-16 09:44:40 | pgsql: Treat JsonConstructorExpr as non-strict |
Previous Message | John Naylor | 2025-09-16 09:30:39 | pgsql: Generate GB18030 mappings from the Unicode Consortium's UCM file |