pgsql: Add more information for WAL records of hash index AMs

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Add more information for WAL records of hash index AMs
Date: 2025-09-12 01:31:36
Message-ID: E1uwsdT-000Gh4-2v@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Add more information for WAL records of hash index AMs

hashdesc.c was missing a couple of fields in its record descriptions, as
of:
- is_prev_bucket_same_wrt for SQUEEZE_PAGE.
- procid for INIT_META_PAGE.
- old_bucket_flag and new_bucket_flag for SPLIT_ALLOCATE_PAGE.

The author has noted the first hole, and I have spotted the others while
double-checking this area of the code. Note that the only data missing
now are the offsets stored in VACUUM_ONE_PAGE. We could perhaps add
them, if somebody sees value in this data, even if it makes the output
larger. These are discarded here.

Author: Kirill Reshke <reshkekirill(at)gmail(dot)com>
Discussion: https://postgr.es/m/CALdSSPjc-OVwtZH0Xrkvg7n=2ZwdbMJzqrm_ed_CfjiAzuKVGg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/528dadf691df3023fbb0bd71da5c6087c2d49d6a

Modified Files
--------------
src/backend/access/rmgrdesc/hashdesc.c | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Richard Guo 2025-09-12 02:13:09 pgsql: Fix misuse of Relids for storing attribute numbers
Previous Message Michael Paquier 2025-09-12 00:58:55 pgsql: Remove whitespace in comment of pg_stat_statements.c