| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Fix incorrect comment in pgstat_backend.c |
| Date: | 2025-09-03 23:35:12 |
| Message-ID: | E1utx0S-000NcY-2E@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Fix incorrect comment in pgstat_backend.c
The counters saved from pgWalUsage, used for the difference calculations
when flushing the backend WAL stats, are updated when calling
pgstat_flush_backend() under PGSTAT_BACKEND_FLUSH_WAL, and not
pgstat_report_wal(). The comment updated in this commit referenced the
latter, but it is perfectly OK to flush the backend stats independently
of the WAL stats.
Noticed while looking at this area of the code, introduced by
76def4cdd7c2 as a copy-pasto.
Backpatch-through: 18
Branch
------
REL_18_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/c91c61b2417d0c36993deff03f09b1f64c821a1b
Modified Files
--------------
src/backend/utils/activity/pgstat_backend.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dean Rasheed | 2025-09-04 10:40:00 | pgsql: Fix replica identity check for INSERT ON CONFLICT DO UPDATE. |
| Previous Message | Tom Lane | 2025-09-03 20:08:03 | pgsql: Make libpq_pipeline.c shorter and more uniform via helper functi |