| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: headerscheck: Ignore Windows-specific header |
| Date: | 2025-08-29 07:25:32 |
| Message-ID: | E1urtUJ-002C6a-2e@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
headerscheck: Ignore Windows-specific header
Ignore src/include/port/win32/sys/resource.h. At least on macOS,
including this results in warnings and errors because of duplication
with system headers:
../src/include/port/win32/sys/resource.h:10:9: warning: 'RUSAGE_CHILDREN' redefined
../src/include/port/win32/sys/resource.h:16:1: error: redefinition of struct or union 'struct rusage'
Since we are also not checking similar system-replacement headers for
Windows, it makes sense to exclude this one, too.
Reviewed-by: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Discussion: https://www.postgresql.org/message-id/flat/1127775.1754417387%40sss.pgh.pa.us
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/da0413373c092295d89d4523be6a956c34d39540
Modified Files
--------------
src/tools/pginclude/headerscheck | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2025-08-29 07:32:34 | pgsql: headerscheck: Document that --with-llvm is required |
| Previous Message | Peter Eisentraut | 2025-08-29 05:41:29 | pgsql: Mark ItemPointer arguments as const in tuple/table lock function |