| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Reduce ExecSeqScan* code size using pg_assume() |
| Date: | 2025-08-11 20:19:38 |
| Message-ID: | E1ulYza-00056b-1Z@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Reduce ExecSeqScan* code size using pg_assume()
fb9f955025f optimized code generation by using specialized variants of
ExecSeqScan* for [not] having a qual, projection etc. This allowed the
compiler to optimize the code out the code for qual / projection. However, as
observed by David Rowley at the time, the compiler couldn't prove the
opposite, i.e. that the qual etc *are* present.
By using pg_assume(), introduced in d65eb5b1b84, we can tell the compiler that
the relevant variables are non-null.
This reduces the code size to a surprising degree and seems to lead to a small
but reproducible performance gain.
Reviewed-by: Amit Langote <amitlangote09(at)gmail(dot)com> Discussion:
https://postgr.es/m/CA+HiwqFk-MbwhfX_kucxzL8zLmjEt9MMcHi2YF=DyhPrSjsBEA@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/b227b0bb4e032e19b3679bedac820eba3ac0d1cf
Modified Files
--------------
src/backend/executor/nodeSeqscan.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2025-08-11 21:03:26 | pgsql: Stamp 18beta3. |
| Previous Message | Tom Lane | 2025-08-11 19:38:07 | pgsql: Last-minute updates for release notes. |