pgsql: Remove unnecessary complication around xmlParseBalancedChunkMemo

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Remove unnecessary complication around xmlParseBalancedChunkMemo
Date: 2025-07-29 16:47:58
Message-ID: E1ugnUc-001LBS-26@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove unnecessary complication around xmlParseBalancedChunkMemory.

When I prepared 71c0921b6 et al yesterday, I was thinking that the
logic involving explicitly freeing the node_list output was still
needed to dodge leakage bugs in libxml2. But I was misremembering:
we introduced that only because with early 2.13.x releases we could
not trust xmlParseBalancedChunkMemory's result code, so we had to
look to see if a node list was returned or not. There's no reason
to believe that xmlParseBalancedChunkMemory will fail to clean up
the node list when required, so simplify. (This essentially
completes reverting all the non-cosmetic changes in 6082b3d5d.)

Reported-by: Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>
Author: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Discussion: https://postgr.es/m/997668.1753802857@sss.pgh.pa.us
Backpatch-through: 13

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/0ae824704070dd4beaa77ef8840017ba2601affc

Modified Files
--------------
src/backend/utils/adt/xml.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2025-07-29 16:57:35 pgsql: Update comment
Previous Message Nathan Bossart 2025-07-29 15:33:06 pgsql: Add commit 1d1612aec7 to .git-blame-ignore-revs.