pgsql: Reap the benefits of not having to avoid leaking PGresults.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Reap the benefits of not having to avoid leaking PGresults.
Date: 2025-07-25 20:42:52
Message-ID: E1ufPFk-000j9G-0G@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Reap the benefits of not having to avoid leaking PGresults.

Remove a bunch of PG_TRY constructs, de-volatilize related
variables, remove some PQclear calls in error paths.
Aside from making the code simpler and shorter, this should
provide some marginal performance gains.

For ease of review, I did not re-indent code within the removed
PG_TRY constructs. That'll be done in a separate patch.

Author: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Reviewed-by: Matheus Alcantara <matheusssilv97(at)gmail(dot)com>
Discussion: https://postgr.es/m/2976982.1748049023@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/80aa9848befc13c188d2775a859deaf172fdd3a2

Modified Files
--------------
contrib/dblink/dblink.c | 96 ++++--------
contrib/postgres_fdw/connection.c | 52 ++-----
contrib/postgres_fdw/postgres_fdw.c | 163 +++++----------------
contrib/postgres_fdw/postgres_fdw.h | 2 +-
.../libpqwalreceiver/libpqwalreceiver.c | 31 +---
src/include/libpq/libpq-be-fe-helpers.h | 13 +-
6 files changed, 83 insertions(+), 274 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2025-07-25 20:46:12 pgsql: Add commit 73873805f to .git-blame-ignore-revs.
Previous Message Tom Lane 2025-07-25 14:57:04 pgsql: Fix dynahash's HASH_FIXED_SIZE ("isfixed") option.