pgpool: Fix watchdog to print inappropriate NOTICE message.

From: Tatsuo Ishii <ishii(at)postgresql(dot)org>
To: pgpool-committers(at)lists(dot)postgresql(dot)org
Subject: pgpool: Fix watchdog to print inappropriate NOTICE message.
Date: 2025-07-25 05:07:12
Message-ID: E1ufAeG-00BqgP-06@gothos.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgpool-committers

Fix watchdog to print inappropriate NOTICE message.

read_ipc_socket_and_process() printed a notice message every time when
it wrote commands to IPC socket even if it was successful. Fix this to
print the notice message only when the write failed.

The reason why this bug was not recognized is, the message appears
only when log_min_messages is set to notice or higher.

Discussion: https://github.com/pgpool/pgpool2/issues/121
Backpatch-through: v4.2

Branch
------
V4_4_STABLE

Details
-------
https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=8312863ae89e2a77bbb519292cb84f6eee00355a

Modified Files
--------------
src/watchdog/watchdog.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)

Browse pgpool-committers by date

  From Date Subject
Next Message Tatsuo Ishii 2025-07-25 05:07:18 pgpool: Fix watchdog to print inappropriate NOTICE message.
Previous Message Tatsuo Ishii 2025-07-25 05:07:07 pgpool: Fix watchdog to print inappropriate NOTICE message.