pgsql: Centralize collection of catalog info needed early in the planne

From: Richard Guo <rguo(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Centralize collection of catalog info needed early in the planne
Date: 2025-07-22 02:23:08
Message-ID: E1ue2eq-0007MK-0G@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Centralize collection of catalog info needed early in the planner

There are several pieces of catalog information that need to be
retrieved for a relation during the early stage of planning. These
include relhassubclass, which is used to clear the inh flag if the
relation has no children, as well as a column's attgenerated and
default value, which are needed to expand virtual generated columns.
More such information may be required in the future.

Currently, these pieces of catalog data are collected in multiple
places, resulting in repeated table_open/table_close calls for each
relation in the rangetable. This patch centralizes the collection of
all required early-stage catalog information into a single loop over
the rangetable, allowing each relation to be opened and closed only
once.

Author: Richard Guo <guofenglinux(at)gmail(dot)com>
Reviewed-by: Robert Haas <robertmhaas(at)gmail(dot)com>
Reviewed-by: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Discussion: https://postgr.es/m/CAMbWs4-bFJ1At4btk5wqbezdu8PLtQ3zv-aiaY3ry9Ymm=jgFQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/904f6a593a06649f77597ab9a72ef97c21e39a93

Modified Files
--------------
src/backend/optimizer/plan/planner.c | 31 +---
src/backend/optimizer/plan/subselect.c | 9 +-
src/backend/optimizer/prep/prepjointree.c | 299 ++++++++++++++++++------------
src/include/optimizer/prep.h | 2 +-
4 files changed, 190 insertions(+), 151 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2025-07-22 05:00:43 pgsql: ecpg: Fix NULL pointer dereference during connection lookup
Previous Message Christoph Berg 2025-07-21 20:52:12 Re: pgsql: Introduce pg_shmem_allocations_numa view