From: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: pg_dump: include comments on not-null constraints on domains, to |
Date: | 2025-07-21 09:35:54 |
Message-ID: | E1udmw5-0000V9-37@gemulon.postgresql.org |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
pg_dump: include comments on not-null constraints on domains, too
Commit e5da0fe3c22b introduced catalog entries for not-null constraints
on domains; but because commit b0e96f311985 (the original work for
catalogued not-null constraints on tables) forgot to teach pg_dump to
process the comments for them, this one also forgot. Add that now.
We also need to teach repairDependencyLoop() about the new type of
constraints being possible for domains.
Backpatch-through: 17
Co-authored-by: jian he <jian(dot)universality(at)gmail(dot)com>
Co-authored-by: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
Reported-by: jian he <jian(dot)universality(at)gmail(dot)com>
Discussion: https://postgr.es/m/CACJufxF-0bqVR=j4jonS6N2Ka6hHUpFyu3_3TWKNhOW_4yFSSg@mail.gmail.com
Branch
------
REL_18_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/f9545e95c5e7ead0c19676ef8c966eb21f573954
Modified Files
--------------
src/bin/pg_dump/pg_dump.c | 160 +++++++++++++++++++++++++++++----------
src/bin/pg_dump/pg_dump.h | 4 +-
src/bin/pg_dump/pg_dump_sort.c | 15 ++--
src/bin/pg_dump/t/002_pg_dump.pl | 30 +++++++-
4 files changed, 160 insertions(+), 49 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Alexander Korotkov | 2025-07-21 12:08:01 | pgsql: Update comment for ReplicationSlot.last_saved_restart_lsn |
Previous Message | David Rowley | 2025-07-21 00:39:36 | Re: pgsql: pg_logicalinspect: Fix possible crash when passing a directory p |