pgsql: Improve the stability of the recovery test 047_checkpoint_physic

From: Alexander Korotkov <akorotkov(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Improve the stability of the recovery test 047_checkpoint_physic
Date: 2025-07-19 12:45:42
Message-ID: E1ud6wg-0075gB-29@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Improve the stability of the recovery test 047_checkpoint_physical_slot

Currently, the comments in 047_checkpoint_physical_slot. It shows an
incomplete intention to wait for checkpoint completion before performing
an immediate database stop. However, an immediate node stop can occur both
before and after checkpoint completion. Both cases should work correctly.
But we would like the test to be more stable and deterministic. This is why
this commit makes this test explicitly wait for the checkpoint completion
log message.

Discussion: https://postgr.es/m/CAPpHfdurV-j_e0pb%3DUFENAy3tyzxfF%2ByHveNDNQk2gM82WBU5A%40mail.gmail.com
Discussion: https://postgr.es/m/aHXLep3OaX_vRTNQ%40paquier.xyz
Author: Alexander Korotkov <akorotkov(at)postgresql(dot)org>
Reviewed-by: Michael Paquier <michael(at)paquier(dot)xyz>
Backpatch-through: 17

Branch
------
REL_17_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/fd39c3cf28396d1fbb8b2a2cdb9fe66b6ad87964

Modified Files
--------------
src/test/recovery/t/047_checkpoint_physical_slot.pl | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Alexander Korotkov 2025-07-19 12:45:55 pgsql: Fix infinite wait when reading a partially written WAL record
Previous Message Alexander Korotkov 2025-07-19 12:45:41 pgsql: Reintroduce test 046_checkpoint_logical_slot