From: | Masahiko Sawada <msawada(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Fix missing FSM vacuum opportunities on tables without indexes. |
Date: | 2025-07-02 06:27:39 |
Message-ID: | E1uWqwV-004JEw-04@gemulon.postgresql.org |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix missing FSM vacuum opportunities on tables without indexes.
Commit c120550edb86 optimized the vacuuming of relations without
indexes (a.k.a. one-pass strategy) by directly marking dead item IDs
as LP_UNUSED. However, the periodic FSM vacuum was still checking if
dead item IDs had been marked as LP_DEAD when attempting to vacuum the
FSM every VACUUM_FSM_EVERY_PAGES blocks. This condition was never met
due to the optimization, resulting in missed FSM vacuum
opportunities.
This commit modifies the periodic FSM vacuum condition to use the
number of tuples deleted during HOT pruning. This count includes items
marked as either LP_UNUSED or LP_REDIRECT, both of which are expected
to result in new free space to report.
Back-patch to v17 where the vacuum optimization for tables with no
indexes was introduced.
Reviewed-by: Melanie Plageman <melanieplageman(at)gmail(dot)com>
Discussion: https://postgr.es/m/CAD21AoBL8m6B9GSzQfYxVaEgvD7-Kr3AJaS-hJPHC+avm-29zw@mail.gmail.com
Backpatch-through: 17
Branch
------
REL_17_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/792238c8b4a1943e91485fa7dac1959f23a9ac1d
Modified Files
--------------
src/backend/access/heap/vacuumlazy.c | 17 +++++++++++------
1 file changed, 11 insertions(+), 6 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Masahiko Sawada | 2025-07-02 06:27:43 | pgsql: Fix missing FSM vacuum opportunities on tables without indexes. |
Previous Message | John Naylor | 2025-07-02 04:52:49 | pgsql: Remove implicit cast from 'void *' |