pgsql: Move code for the bytea data type from varlena.c to new bytea.c

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Move code for the bytea data type from varlena.c to new bytea.c
Date: 2025-07-02 00:52:52
Message-ID: E1uWliW-004GxT-2H@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Move code for the bytea data type from varlena.c to new bytea.c

This commit moves all the routines related to the bytea data type into
its own new file, called bytea.c, clearing some of the bloat in
varlena.c. This includes the routines for:
- Input, output, receive and send
- Comparison
- Casts to integer types
- bytea-specific functions

The internals of the routines moved here are unchanged, with one
exception. This comes with a twist in bytea_string_agg_transfn(), where
the call to makeStringAggState() is replaced by the internals of this
routine, still located in varlena.c. This simplifies the move to the
new file by not having to expose makeStringAggState().

Author: Aleksander Alekseev <aleksander(at)timescale(dot)com>
Reviewed-by: Peter Eisentraut <peter(at)eisentraut(dot)org>
Discussion: https://postgr.es/m/CAJ7c6TMPVPJ5DL447zDz5ydctB8OmuviURtSwd=PHCRFEPDEAQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b45242fd30ffa6e1e7f490cc400ecbd966880f41

Modified Files
--------------
src/backend/utils/adt/Makefile | 1 +
src/backend/utils/adt/bytea.c | 1143 ++++++++++++++++++++++++++++++++++
src/backend/utils/adt/meson.build | 1 +
src/backend/utils/adt/varlena.c | 1214 ++-----------------------------------
4 files changed, 1203 insertions(+), 1156 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2025-07-02 04:49:57 pgsql: Fix bug in archive streamer with LZ4 decompression
Previous Message Michael Paquier 2025-07-01 23:40:15 pgsql: Show sizes of FETCH queries as constants in pg_stat_statements