| From: | Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Add CHECK_FOR_INTERRUPTS into pg_numa_query_pages |
| Date: | 2025-07-01 10:59:54 |
| Message-ID: | E1uWYiQ-004B7W-0o@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Add CHECK_FOR_INTERRUPTS into pg_numa_query_pages
Querying the NUMA status can be quite time consuming, especially with
large shared buffers. 8cc139bec34a called numa_move_pages() once, for
all buffers, and we had to wait for the syscall to complete.
But with the chunking, introduced by 7fe2f67c7c to work around a kernel
bug, we can do CHECK_FOR_INTERRUPTS() after each chunk, allowing users
to abort the execution.
Reviewed-by: Christoph Berg <myon(at)debian(dot)org>
Reviewed-by: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>
Discussion: https://postgr.es/m/aEtDozLmtZddARdB@msg.df7cb.de
Backpatch-through: 18
Branch
------
REL_18_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/54ac4944c36f8f6cfc4deaa3f828118b564e1d3d
Modified Files
--------------
src/port/pg_numa.c | 3 +++
1 file changed, 3 insertions(+)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2025-07-01 11:03:28 | Re: pgsql: Introduce pg_shmem_allocations_numa view |
| Previous Message | Tomas Vondra | 2025-07-01 10:59:35 | pgsql: Add CHECK_FOR_INTERRUPTS into pg_numa_query_pages |