pgsql: Disallow "=" in names of reloptions and foreign-data options.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Disallow "=" in names of reloptions and foreign-data options.
Date: 2025-06-02 19:23:03
Message-ID: E1uMAkQ-00040l-2h@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Disallow "=" in names of reloptions and foreign-data options.

We store values for these options as array elements with the syntax
"name=value", hence a name containing "=" confuses matters when
it's time to read the array back in. Since validation of the
options is often done (long) after this conversion to array format,
that leads to confusing and off-point error messages. We can
improve matters by rejecting names containing "=" up-front.

(Probably a better design would have involved pairs of array
elements, but it's too late now --- and anyway, there's no
evident use-case for option names like this. We already
reject such names in some other contexts such as GUCs.)

Reported-by: Chapman Flack <jcflack(at)acm(dot)org>
Author: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Reviewed-by: Chapman Flack <jcflack(at)acm(dot)org>
Discussion: https://postgr.es/m/6830EB30.8090904@acm.org
Backpatch-through: 13

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/cd31eaaebc406d043f5dc240f8849d640490e707

Modified Files
--------------
contrib/file_fdw/input/file_fdw.source | 2 ++
contrib/file_fdw/output/file_fdw.source | 5 +++++
src/backend/access/common/reloptions.c | 17 +++++++++++++----
src/backend/commands/foreigncmds.c | 15 +++++++++++++--
4 files changed, 33 insertions(+), 6 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Fujii Masao 2025-06-03 01:04:15 pgsql: Rename log_lock_failure GUC to log_lock_failures for consistency
Previous Message Melanie Plageman 2025-06-02 14:55:36 pgsql: Correct heap vacuum boundary state setup ordering