| From: | Jacob Champion <jchampion(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: oauth: Correct missing comma in Requires.private |
| Date: | 2025-05-23 20:09:25 |
| Message-ID: | E1uIYho-000Sb1-1y@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
oauth: Correct missing comma in Requires.private
I added libcurl to the Requires.private section of libpq.pc in commit
b0635bfda, but I missed that the Autoconf side needs commas added
explicitly. Configurations which used both --with-libcurl and
--with-openssl ended up with the following entry:
Requires.private: libssl, libcrypto libcurl
The pkg-config parser appears to be fairly lenient in this case, and
accepts the whitespace as an equivalent separator, but let's not rely on
that. Add an add_to_list macro (inspired by Makefile.global's
add_to_path) to build up the PKG_CONFIG_REQUIRES_PRIVATE list correctly.
Reported-by: Wolfgang Walther <walther(at)technowledgy(dot)de>
Reviewed-by: Fabrízio de Royes Mello <fabriziomello(at)gmail(dot)com>
Discussion: https://postgr.es/m/CAOYmi+k2z7Rqj5xiWLUT0+bSXLvdE7TYgS5gCOSqSyXyTSSXiQ@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/a8f093234d78ff2bbcf6489ac213064aa584ad2b
Modified Files
--------------
src/interfaces/libpq/Makefile | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2025-05-23 21:02:35 | pgsql: doc PG 18 relnotes: clarify btree skip-scan item |
| Previous Message | Bruce Momjian | 2025-05-23 20:01:31 | pgsql: doc PG 18 relnotes: update to current |