pgsql: aio: Fix possible state confusions due to interrupt processing

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: aio: Fix possible state confusions due to interrupt processing
Date: 2025-05-20 01:08:41
Message-ID: E1uHBTE-002TFu-3D@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

aio: Fix possible state confusions due to interrupt processing

elog()/ereport() process interrupts, iff the log message is < ERROR and the
log message will be emitted. aio's debug messages are emitted via ereport(),
but in some places the code is not ready for interrupts to be processed.

Fix the issue using a few different methods:

1) handle interrupts arriving concurrently - in some places it's easy to
detect that by fetching the handle's generation a bit earlier
2) Check if interrupts made the work needing to be done obsolete
3) Disallow interrupts, as there's no sane way to make interrupt processing
safe

To prevent some similar issues from being re-introduced, assert that
interrupts are held in pgaio_io_update_state().

This commit also fixes the contents of a debug message I added in 039bfc457e4.

Reported-by: Alexander Lakhin <exclusion(at)gmail(dot)com>
Reviewed-by: Noah Misch <noah(at)leadboat(dot)com>
Discussion: https://postgr.es/m/mvpm7ga3dfgz7bvum22hmuz26cariylmcppb3irayftc7bwk3r@l7gb6gr7azhc

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/acad909321a4742a78b83cf7e975e627e786af5c

Modified Files
--------------
src/backend/storage/aio/aio.c | 113 ++++++++++++++++++++++++++++++++++++------
1 file changed, 99 insertions(+), 14 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2025-05-20 05:40:05 pgsql: doc: Clarify use of _ccnew and _ccold in REINDEX CONCURRENTLY
Previous Message Heikki Linnakangas 2025-05-19 15:52:20 pgsql: Fix deparsing FETCH FIRST <expr> ROWS WITH TIES