pgsql: psql: Fix assertion failures with pipeline mode

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: psql: Fix assertion failures with pipeline mode
Date: 2025-04-24 03:23:47
Message-ID: E1u7nBi-001VIu-2d@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

psql: Fix assertion failures with pipeline mode

A correct cocktail of COPY FROM, SELECT and/or DML queries and
\syncpipeline was able to break the logic in charge of discarding
results of a pipeline, done in discardAbortedPipelineResults(). Such
sequence make the backend generate a FATAL, due to a protocol
synchronization loss.

This problem comes down to the fact that we did not consider the case of
libpq returning a PGRES_FATAL_ERROR when discarding the results of an
aborted pipeline. The discarding code is changed so as this result
status is handled as a special case, with the caller of
discardAbortedPipelineResults() being responsible for consuming the
result.

A couple of tests are added to cover the problems reported, bringing an
interesting gain in coverage as there were no tests in the tree covering
the case of protocol synchronization loss.

Issue introduced by 41625ab8ea3d.

Reported-by: Alexander Kozhemyakin <a(dot)kozhemyakin(at)postgrespro(dot)ru>
Author: Anthonin Bonnefoy <anthonin(dot)bonnefoy(at)datadoghq(dot)com>
Co-authored-by: Michael Paquier <michael(at)paquier(dot)xyz>
Discussion: https://postgr.es/m/ebf6ce77-b180-4d6b-8eab-71f641499ddf@postgrespro.ru

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/3631612eae9c2def99151c4f36b1b3771f53cba7

Modified Files
--------------
src/bin/psql/common.c | 17 +++++++++++++++++
src/bin/psql/t/001_basic.pl | 41 +++++++++++++++++++++++++++++++++++++++++
2 files changed, 58 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Amit Kapila 2025-04-24 05:10:37 pgsql: Fix data loss in logical replication.
Previous Message Michael Paquier 2025-04-24 00:21:30 pgsql: Add sanity check for dshash entries when reading pgstats file