pgsql: Test restartpoints in archive recovery.

From: Noah Misch <noah(at)leadboat(dot)com>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Test restartpoints in archive recovery.
Date: 2025-04-20 15:30:17
Message-ID: E1u6Wcb-000yAO-1L@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Test restartpoints in archive recovery.

v14 commit 1f95181b44c843729caaa688f74babe9403b5850 and its v13
equivalent caused timing-dependent failures in archive recovery, at
restartpoints. The symptom was "invalid magic number 0000 in log
segment X, offset 0", "unexpected pageaddr X in log segment Y, offset 0"
[X < Y], or an assertion failure. Commit
3635a0a35aafd3bfa80b7a809bc6e91ccd36606a and predecessors back-patched
v15 changes to fix that. This test reproduces the problem
probabilistically, typically in less than 1000 iterations of the test.
Hence, buildfarm and CI runs would have surfaced enough failures to get
attention within a day.

Reported-by: Arun Thirupathi <arunth(at)google(dot)com>
Discussion: https://postgr.es/m/20250306193013.36.nmisch@google.com
Backpatch-through: 13

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/41ffd9d6a72486efb182c4f937866cf6e069a8ec

Modified Files
--------------
src/test/recovery/t/045_archive_restartpoint.pl | 57 +++++++++++++++++++++++++
1 file changed, 57 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Noah Misch 2025-04-20 19:04:54 pgsql: Comment on need to MarkBufferDirty() if omitting DELAY_CHKPT_STA
Previous Message David Rowley 2025-04-20 10:13:15 pgsql: Fix issue with ORDER BY / DISTINCT aggregates and FILTER