pgsql: Make pg_upgrade log message with control file path translatable.

From: Fujii Masao <fujii(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Make pg_upgrade log message with control file path translatable.
Date: 2025-04-18 09:37:08
Message-ID: E1u5i9k-000cEX-0H@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Make pg_upgrade log message with control file path translatable.

Commit 173c97812ff replaced the hardcoded "global/pg_control" in pg_upgrade
log message with a string literal concatenation of XLOG_CONTROL_FILE macro.
However, this change made the message untranslatable.

This commit fixes the issue by using %s with XLOG_CONTROL_FILE instead of
that literal concatenation, allowing the message to be translated properly.
It also wraps the file path in double quotes for consistency with similar
log messages.

Author: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Reviewed-by: Masao Fujii <masao(dot)fujii(at)gmail(dot)com>
Discussion: https://postgr.es/m/20250407.155546.2129693791769531891.horikyota.ntt@gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/3aad76a0a970faf22ea38dd61b5668d480b5a92f

Modified Files
--------------
src/bin/pg_upgrade/controldata.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2025-04-19 09:54:18 pgsql: Rename injection points used in AIO tests
Previous Message Tatsuo Ishii 2025-04-18 00:41:13 pgsql: Doc: fix missing comma at the end of a line.