pgsql: Revert "Add HINT for restartpoint race with KeepFileRestoredFrom

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Revert "Add HINT for restartpoint race with KeepFileRestoredFrom
Date: 2025-04-06 06:25:53
Message-ID: E1u1JS5-002vDA-29@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Revert "Add HINT for restartpoint race with KeepFileRestoredFromArchive()."

This reverts commit 8ad6c5dbbe5a, which was a commit specific to v14 and
older branches as the race condition between restartpoints and
KeepFileRestoredFromArchive() still existed.

1f95181b44c8 has worsened the situation on these two branches, causing
spurious failures in archive recovery (neither streaming nor archive
recovery) with concurrent restartpoints. The same logic as v15 and
newer versions will be applied in some follow-up commits to close this
problem, making this HINT not necessary anymore.

Reported-by: Arun Thirupathi
Discussion: https://postgr.es/m/20250306193013.36.nmisch@google.com
Backpatch-through: 13

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/e77d9cd4f52ec40ec9edc823ee89612ddf300795

Modified Files
--------------
src/backend/access/transam/xlog.c | 5 +----
src/backend/storage/file/fd.c | 10 ++--------
2 files changed, 3 insertions(+), 12 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2025-04-06 06:37:10 pgsql: Don't ERROR on PreallocXlogFiles() race condition.
Previous Message Michael Paquier 2025-04-06 06:08:41 pgsql: Remove XLogFileInit() ability to unlink a pre-existing file.