| From: | Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Remove direct handling of reloptions for toast tables |
| Date: | 2025-03-14 08:29:35 |
| Message-ID: | E1tt0QB-002Phj-1s@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Remove direct handling of reloptions for toast tables
It doesn't actually work, even with allow_system_table_mods turned on:
the ALTER TABLE operation is rejected by ATSimplePermissions(), so even
the error message we're adding in this commit is unreachable.
Add a test case for it.
Author: Nikolay Shaplov <dhyan(at)nataraj(dot)su>
Discussion: https://postgr.es/m/1913854.tdWV9SEqCh@thinkpad-pgpro
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/1548c3a30436dd825cfbf57923c6766b2fddd355
Modified Files
--------------
src/backend/commands/tablecmds.c | 3 ++-
src/test/modules/unsafe_tests/expected/alter_system_table.out | 7 +++++++
src/test/modules/unsafe_tests/sql/alter_system_table.sql | 4 ++++
3 files changed, 13 insertions(+), 1 deletion(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2025-03-14 09:54:41 | pgsql: Simplify and generalize PrepareSortSupportFromIndexRel() |
| Previous Message | Thomas Munro | 2025-03-14 08:24:35 | pgsql: Respect changing pin limits in read_stream.c. |