pgsql: Rename some signal and interrupt handling functions for consiste

From: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Rename some signal and interrupt handling functions for consiste
Date: 2025-03-05 14:30:16
Message-ID: E1tpplI-000v5T-23@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Rename some signal and interrupt handling functions for consistency

The usual pattern for handling a signal is that the signal handler
sets a flag and calls SetLatch(MyLatch), and CHECK_FOR_INTERRUPTS() or
other code that is part of a wait loop calls another function to deal
with it. The naming of the functions involved was a bit inconsistent,
however. CHECK_FOR_INTERRUPTS() calls ProcessInterrupts() to do the
heavy-lifting, but the analogous functions in aux processes were
called HandleMainLoopInterrupts(), HandleStartupProcInterrupts(),
etc. Similarly, most subroutines of ProcessInterrupts() were called
Process*(), but some were called Handle*().

To make things less confusing, rename all the functions that are part
of the overall signal/interrupt handling system but are not executed
in a signal handler to e.g. ProcessSomething(), rather than
HandleSomething(). The "Process" prefix is now consistently used in
the non-signal-handler functions, and the "Handle" prefix in functions
that are part of signal handlers, except for some completely unrelated
functions that clearly have nothing to do with signal or interrupt
handling.

Reviewed-by: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Discussion: https://www.postgresql.org/message-id/8a384b26-1499-41f6-be33-64b801fb98b8@iki.fi

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/635f580120b99f6df71d7c12749b22acde61c5ad

Modified Files
--------------
src/backend/access/transam/parallel.c | 16 ++++++++--------
src/backend/access/transam/xlogrecovery.c | 12 ++++++------
src/backend/postmaster/autovacuum.c | 6 +++---
src/backend/postmaster/bgwriter.c | 2 +-
src/backend/postmaster/checkpointer.c | 10 +++++-----
src/backend/postmaster/interrupt.c | 6 +++---
src/backend/postmaster/pgarch.c | 8 ++++----
src/backend/postmaster/startup.c | 6 +++---
src/backend/postmaster/walsummarizer.c | 16 ++++++++--------
src/backend/postmaster/walwriter.c | 2 +-
src/backend/replication/logical/applyparallelworker.c | 12 ++++++------
src/backend/tcop/postgres.c | 4 ++--
src/include/access/parallel.h | 2 +-
src/include/postmaster/interrupt.h | 2 +-
src/include/postmaster/startup.h | 2 +-
src/include/replication/logicalworker.h | 2 +-
16 files changed, 54 insertions(+), 54 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Geoghegan 2025-03-05 14:37:00 pgsql: Show index search count in EXPLAIN ANALYZE.
Previous Message Álvaro Herrera 2025-03-05 12:51:42 pgsql: Add ALTER TABLE ... ALTER CONSTRAINT ... SET [NO] INHERIT