pgsql: Skip logical decoding of already-aborted transactions.

From: Masahiko Sawada <msawada(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Skip logical decoding of already-aborted transactions.
Date: 2025-02-13 00:32:37
Message-ID: E1tiN9h-006ovP-4a@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Skip logical decoding of already-aborted transactions.

Previously, transaction aborts were detected concurrently only during
system catalog scans while replaying a transaction in streaming mode.

This commit adds an additional CLOG lookup to check the transaction
status, allowing the logical decoding to skip changes also when it
doesn't touch system catalogs, if the transaction is already
aborted. This optimization enhances logical decoding performance,
especially for large transactions that have already been rolled back,
as it avoids unnecessary disk or network I/O.

To avoid potential slowdowns caused by frequent CLOG lookups for small
transactions (most of which commit), the CLOG lookup is performed only
for large transactions before eviction. The performance benchmark
results showed there is not noticeable performance regression due to
CLOG lookups.

Reviewed-by: Amit Kapila, Peter Smith, Vignesh C, Ajin Cherian
Reviewed-by: Dilip Kumar, Andres Freund
Discussion: https://postgr.es/m/CAD21AoDht9Pz_DFv_R2LqBTBbO4eGrpa9Vojmt5z5sEx3XwD7A@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/072ee847ad4c3fb52b0c24f7dddbe0798bd70c24

Modified Files
--------------
contrib/test_decoding/expected/stats.out | 42 +++++-
contrib/test_decoding/expected/stream.out | 6 +
contrib/test_decoding/sql/stats.sql | 20 ++-
contrib/test_decoding/sql/stream.sql | 6 +
src/backend/replication/logical/reorderbuffer.c | 186 +++++++++++++++++++-----
src/include/replication/reorderbuffer.h | 32 +++-
6 files changed, 246 insertions(+), 46 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Masahiko Sawada 2025-02-13 00:55:38 pgsql: Rename RBTXN_PREPARE to RBTXN_IS_PREPARE for better clarificatio
Previous Message Nathan Bossart 2025-02-12 21:46:40 pgsql: Remove unneeded volatile qualifier in fmgr.c.