pgsql: Refactor pl_funcs.c to provide a usage-independent tree walker.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Refactor pl_funcs.c to provide a usage-independent tree walker.
Date: 2025-02-11 17:49:46
Message-ID: E1thuOH-006aai-Ur@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Refactor pl_funcs.c to provide a usage-independent tree walker.

We haven't done this up to now because there was only one use-case,
namely plpgsql_free_function_memory's search for expressions to clean
up. However an upcoming patch has another need for walking plpgsql
functions' statement trees, so let's create sharable tree-walker
infrastructure in the same style as expression_tree_walker().

This patch actually makes the code shorter, although that's
mainly down to having used a more compact coding style. (I didn't
write a separate subroutine for each statement type, and I made
use of some newer notations like foreach_ptr.)

Author: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Reviewed-by: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
Reviewed-by: Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com>
Discussion: https://postgr.es/m/CACxu=vJaKFNsYxooSnW1wEgsAO5u_v1XYBacfVJ14wgJV_PYeg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/6a7283dd2f1c573f2cf3daaf14e8a246577da57d

Modified Files
--------------
src/pl/plpgsql/src/pl_funcs.c | 582 ++++++++++++++++++------------------------
1 file changed, 244 insertions(+), 338 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2025-02-11 17:56:57 pgsql: config: Rename "Asynchronous Behavior" to "I/O"
Previous Message Peter Eisentraut 2025-02-11 10:18:15 pgsql: Replace AssertMacro() with Assert() when not in macro