pgsql: Lock table in ShareUpdateExclusive when importing index stats.

From: Jeff Davis <jdavis(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Lock table in ShareUpdateExclusive when importing index stats.
Date: 2025-02-10 20:59:25
Message-ID: E1thasG-006Qfp-V5@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Lock table in ShareUpdateExclusive when importing index stats.

Follow locking behavior of ANALYZE when importing statistics. In
particular, when importing index statistics, the table must be locked
in ShareUpdateExclusive mode. Fixes bug reportd by Jian He.

ANALYZE doesn't update statistics on partitioned indexes, and the
locking requirements are slightly different for in-place updates on
partitioned indexes versus normal indexes. To be conservative, lock
both the partitioned table and the partitioned index in
ShareUpdateExclusive mode when importing stats for a partitioned
index.

Author: Corey Huinker
Reported-by: Jian He
Reviewed-by: Michael Paquier
Discussion: https://www.postgresql.org/message-id/CACJufxGreTY7qsCV8%2BBkuv0p5SXGTScgh%3DD%2BDq6%3D%2B_%3DXTp7FWg%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/9f12da78d9538016efccbf17e6f816f1c286b7f5

Modified Files
--------------
src/backend/statistics/stat_utils.c | 70 ++++++++++++++++----
src/test/regress/expected/stats_import.out | 103 +++++++++++++++++++++++++++++
src/test/regress/sql/stats_import.sql | 68 +++++++++++++++++++
3 files changed, 228 insertions(+), 13 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2025-02-10 21:31:34 pgsql: Adapt appendPsqlMetaConnect() to the new fmtId() encoding expect
Previous Message Andres Freund 2025-02-10 17:30:44 pgsql: Fix type in test_escape test