From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Refactor TAP test code for file comparisons into new routine in |
Date: | 2025-02-09 07:52:58 |
Message-ID: | E1th27d-006ASu-PO@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Refactor TAP test code for file comparisons into new routine in Utils.pm
This unifies the output used should any differences be found in the
files provided, information that 027_stream_regress did not show on
failures. TAP tests of pg_combinebackup and pg_upgrade now rely on the
refactored routine, reducing the dependency to the diff command. The
callers of this routine can optionally specify a custom line-comparison
function.
There are a couple of tests that still use directly a diff command:
001_pg_bsd_indent, 017_shm and test_json_parser's 003. These rely on
different properties and are left out for now.
Extracted from a larger patch by the same author.
Author: Ashutosh Bapat
Discussion: https://postgr.es/m/Z6RQS-tMzGYjlA-H@paquier.xyz
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/169208092f5c98a6021b23b38f03a5d65f84ad96
Modified Files
--------------
src/bin/pg_combinebackup/t/002_compare_backups.pl | 19 ++---------
src/bin/pg_upgrade/t/002_pg_upgrade.pl | 22 +++---------
src/test/perl/PostgreSQL/Test/Utils.pm | 41 +++++++++++++++++++++++
src/test/recovery/t/027_stream_regress.pl | 14 ++++----
4 files changed, 53 insertions(+), 43 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2025-02-09 11:44:09 | pgsql: Make TLS write functions' buffer arguments pointers const |
Previous Message | Tom Lane | 2025-02-08 03:14:12 | pgsql: PDF docs build: avoid spurious "warn" in build logs. |