pgsql: pgcrypto: Remove static storage class from variables

From: Daniel Gustafsson <dgustafsson(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: pgcrypto: Remove static storage class from variables
Date: 2025-02-06 15:26:37
Message-ID: E1tg3m1-005guQ-Gs@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

pgcrypto: Remove static storage class from variables

Variables p, sp and ep were labeled with static storage class
but are all assigned before use so they cannot carry any data
across calls. Fix by removing the static label.

Also while in there, make the magic variable const as it will
never change.

Author: Japin Li <japinli(at)hotmail(dot)com>
Reviewed-by: Daniel Gustafsson <daniel(at)yesql(dot)se>
Reviewed-by: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Discussion: https://postgr.es/m/ME0P300MB0445096B67ACE8CE25772F00B6F72@ME0P300MB0445.AUSP300.PROD.OUTLOOK.COM

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/affd38e55a3cabbc4c64198dde71c22a94877690

Modified Files
--------------
contrib/pgcrypto/crypt-md5.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Nathan Bossart 2025-02-06 17:59:57 pgsql: Fix autovacuum_vacuum_max_threshold's GUC description.
Previous Message Michael Paquier 2025-02-06 01:41:03 pgsql: injection_points: Re-enable permutation in isolation test "basic