pgsql: Show more-intuitive titles for psql commands \dt, \di, etc.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Show more-intuitive titles for psql commands \dt, \di, etc.
Date: 2025-02-05 17:46:03
Message-ID: E1tfjTO-005Xev-Q9@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Show more-intuitive titles for psql commands \dt, \di, etc.

If exactly one relation type is requested in a command of the \dtisv
family, say "tables", "indexes", etc instead of "relations". This
should cover the majority of actual uses, without creating a huge
number of new translatable strings. The error messages for no
matching relations are adjusted as well.

In passing, invent "pg_log_error_internal()" to be used for frontend
error messages that don't seem to need translation, analogously to
errmsg_internal() in the backend. The implementation is a bit cheesy,
being just a macro to prevent xgettext from recognizing a trigger
keyword. This won't avoid a useless gettext lookup cycle at runtime
--- but surely we don't care about an extra microsecond or two in
what's supposed to be a can't-happen case. I (tgl) also made
"pg_fatal_internal()", though it's not used in this patch.

Author: Greg Sabino Mullane <htamfids(at)gmail(dot)com>
Reviewed-by: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Discussion: https://postgr.es/m/CAKAnmm+7o93fQV-RFkGaN1QnP-0D4d3JTykD+cLueqjDMKdfag@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a14707da564e8c94bd123f0e3a75e194fd7ef56a

Modified Files
--------------
src/bin/psql/describe.c | 65 +++++++++++++++++++++++++++++---
src/include/common/logging.h | 7 ++++
src/test/regress/expected/dependency.out | 2 +-
src/test/regress/expected/psql.out | 42 ++++++++++-----------
4 files changed, 88 insertions(+), 28 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Nathan Bossart 2025-02-05 21:49:56 pgsql: Introduce autovacuum_vacuum_max_threshold.
Previous Message Daniel Gustafsson 2025-02-05 13:10:01 pgsql: doc: Update links which returned 404