| From: | Alexander Korotkov <akorotkov(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: pg_controldata: Fix possible errors on corrupted pg_control |
| Date: | 2025-02-04 22:47:02 |
| Message-ID: | E1tfRh8-005P6H-Nn@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
pg_controldata: Fix possible errors on corrupted pg_control
Protect against malformed timestamps. Also protect against negative WalSegSz
as it triggers division by zero:
((0x100000000UL) / (WalSegSz)) can turn into zero in
XLogFileName(xlogfilename, ControlFile->checkPointCopy.ThisTimeLineID,
segno, WalSegSz);
because if WalSegSz is -1 then by arithmetic rules in C we get
0x100000000UL / 0xFFFFFFFFFFFFFFFFUL == 0.
Author: Ilyasov Ian <ianilyasov(at)outlook(dot)com>
Author: Anton Voloshin <a(dot)voloshin(at)postgrespro(dot)ru>
Backpatch-through: 13
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/ff1975ddd0270703306dee56601b17742d0934b6
Modified Files
--------------
src/bin/pg_controldata/pg_controldata.c | 25 ++++++++++++++++++-------
1 file changed, 18 insertions(+), 7 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2025-02-04 23:19:14 | pgsql: meson: Add missing dependencies to libpq_pipeline test |
| Previous Message | Alexander Korotkov | 2025-02-04 22:47:01 | pgsql: pg_controldata: Fix possible errors on corrupted pg_control |