pgsql: Remove obsolete restriction on the range of log_rotation_size.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Remove obsolete restriction on the range of log_rotation_size.
Date: 2025-01-31 19:37:03
Message-ID: E1tdwp5-004g1b-Nt@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove obsolete restriction on the range of log_rotation_size.

When syslogger.c was first written, we didn't want to assume that
all platforms have 64-bit ftello. But we've been assuming that
since v13 (cf commit 799d22461), so let's use that in syslogger.c
and allow log_rotation_size to range up to INT_MAX kilobytes.

The old code effectively limited log_rotation_size to 2GB regardless
of platform. While nobody's complained, that doesn't seem too far
away from what might be thought reasonable these days.

I noticed this while searching for instances of "1024L" in connection
with commit 041e8b95b. These were the last such instances.
(We still have instances of L-suffixed literals, but most of them
are associated with wait intervals for pg_usleep or similar functions.
I don't see any urgent reason to change that.)

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d4c3a6b8ad830882066122081a7141ecd573f45d

Modified Files
--------------
src/backend/postmaster/syslogger.c | 14 ++++++++------
src/backend/utils/misc/guc_tables.c | 2 +-
2 files changed, 9 insertions(+), 7 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2025-01-31 20:17:23 pgsql: Doc: add commentary about cowboy assignment of maintenance_work_
Previous Message Tom Lane 2025-01-31 18:52:52 pgsql: Get rid of our dependency on type "long" for memory size calcula